Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI: Good contrast / WCAG compatibility #1315

Closed
6543 opened this issue Oct 21, 2022 · 4 comments
Closed

UI: Good contrast / WCAG compatibility #1315

6543 opened this issue Oct 21, 2022 · 4 comments
Labels
summary it's a summary for lot of issues ui frontend related ux user experience

Comments

@6543
Copy link
Member

6543 commented Oct 21, 2022

" ... WCAG compatibility is pretty important, at least AA grade ..."


#468 (comment), #468 (comment)

@6543 6543 added ui frontend related ux user experience summary it's a summary for lot of issues labels Oct 21, 2022
@6543
Copy link
Member Author

6543 commented Oct 21, 2022

@tecosaur:

This seems like the place to plop UI feedback? I've just started using Woodpecker and I'm sorry to say that the dark mode contrast is atrocious.

image

Let alone WCAG AAA, this fails WCAG AA standards of accessibility.

image
image

I recommend https://accessible-colors.com/ for checking that there's sufficient contrast between foreground and background colours.

Here's what #CCCFD4 looks like:

image

Copying Gitea's default foreground #bbc0ca is probably another decent option (it's 2/3 of the way to AAA from AA).

On a more stylistic note, I don't think the dark borders do the design any favours either. Here's a lighter version:

image

There are other improvements that can be made, but this would be a good starting point I think 🙂.


#468 (comment)

@6543 6543 mentioned this issue Oct 21, 2022
13 tasks
@6543
Copy link
Member Author

6543 commented Oct 21, 2022

https://wave.webaim.org/

@qwerty287
Copy link
Contributor

It looks like we're AA compatible, for AAA we would have to change text color (only in dark mode, light is AAA).

(checked from header on repos view)

@qwerty287
Copy link
Contributor

I just checked again: It only complains about the following

  • alternative text color (this one is more light and e.g. used in pipeline list for the pipeline PID)
  • header in light mode

I can't really tell whether we need to improve accessibility here, but especially the first is that light on purpose, so I probably wouldn't change this and close this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
summary it's a summary for lot of issues ui frontend related ux user experience
Projects
None yet
Development

No branches or pull requests

3 participants