Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Kubernetes tolerations support #2231

Closed
4 tasks done
klinux opened this issue Aug 17, 2023 · 3 comments
Closed
4 tasks done

Kubernetes tolerations support #2231

klinux opened this issue Aug 17, 2023 · 3 comments
Labels
backend/kubernetes feature add new functionality good first issue Likely to be an easy fix

Comments

@klinux
Copy link
Contributor

klinux commented Aug 17, 2023

Clear and concise description of the problem

We can set the nodeSelector in the Kubernetes Backend, but if node pool has any taint configuration jobs can't be scheduled.

Suggested solution

I think that Kubernetes backend needs to support tolerations in the backend_settings.

Alternative

No response

Additional context

No response

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@klinux klinux added the feature add new functionality label Aug 17, 2023
@pat-s
Copy link
Contributor

pat-s commented Aug 17, 2023

@6543 6543 added good first issue Likely to be an easy fix backend/kubernetes labels Aug 18, 2023
@klinux
Copy link
Contributor Author

klinux commented Aug 18, 2023

@pat-s thank you I submitted this PR #2249

@zc-devs
Copy link
Contributor

zc-devs commented Sep 24, 2023

@6543, it can be closed as completed in #2249, I think.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backend/kubernetes feature add new functionality good first issue Likely to be an easy fix
Projects
None yet
Development

No branches or pull requests

5 participants