style: Address lint warnings

Avoid NullPointerExceptions.

Author: dcalhoun

Diff for: libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergKitEditorFragment.java

@@ -60,6 +60,7 @@
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.Locale;
 import java.util.Map;
@@ -69,6 +70,7 @@
 import okhttp3.Headers;
 import okhttp3.OkHttpClient;
 import okhttp3.Request;
+import okhttp3.Request.Builder;
 import okhttp3.Response;
 import okhttp3.ResponseBody;
 
@@ -104,7 +106,7 @@ public class GutenbergKitEditorFragment extends EditorFragmentAbstract implement
 
     private boolean mEditorDidMount;
 
-    @Nullable private static Map<String, Object> mSettings;
+    @NonNull private static Map<String, Object> mSettings = Collections.emptyMap();
     private static boolean mIsPrivate = false;
     private static boolean mIsPrivateAtomic = false;
     @NonNull OkHttpClient mHttpClient = new OkHttpClient();
@@ -113,7 +115,7 @@ public static GutenbergKitEditorFragment newInstance(Context context,
                                                          boolean isNewPost,
                                                          GutenbergWebViewAuthorizationData webViewAuthorizationData,
                                                          boolean jetpackFeaturesEnabled,
-                                                         @Nullable Map<String, Object> settings,
+                                                         @NonNull Map<String, Object> settings,
                                                          boolean isPrivate,
                                                          boolean isPrivateAtomic) {
         GutenbergKitEditorFragment fragment = new GutenbergKitEditorFragment();
@@ -600,7 +602,7 @@ public boolean canIntercept(@NonNull WebResourceRequest request) {
     }
 
     boolean isSiteHostedMediaFile(@NonNull String urlString) {
-        String siteURL = (String) (mSettings != null ? mSettings.get("siteURL") : "");
+        String siteURL = (String) mSettings.get("siteURL");
         Set<String> mediaExtensions = new HashSet<>(Arrays.asList(
                 "jpg", "jpeg", "png", "gif", "bmp", "webp",
                 "mp4", "mov", "avi", "mkv",
@@ -642,15 +644,19 @@ public WebResourceResponse handleRequest(@NonNull WebResourceRequest request) {
             proxyUrl = getPrivateResourceProxyUrl(url);
         }
 
+        String authHeader = (String) mSettings.get("authHeader");
+        if (authHeader == null) {
+            return null;
+        }
+
         try {
-            Request okHttpRequest = new Request.Builder()
+            Request okHttpRequest = new Builder()
                     .url(proxyUrl)
                     .headers(Headers.of(request.getRequestHeaders()))
-                    .addHeader("Authorization", mSettings.get("authHeader").toString())
+                    .addHeader("Authorization", authHeader)
                     .build();
 
             Response response = mHttpClient.newCall(okHttpRequest).execute();
-
             ResponseBody body = response.body();
             if (body == null) {
                 return null;
@@ -674,6 +680,11 @@ public WebResourceResponse handleRequest(@NonNull WebResourceRequest request) {
     }
 
     private static @NonNull String getPrivateResourceProxyUrl(@NonNull Uri url) {
+        String path = url.getPath();
+        if (path != null && path.startsWith("/")) {
+            path = path.substring(1); // Remove leading '/'
+        }
+
         Uri newUri = new Uri.Builder()
                 .scheme("https")
                 .authority("public-api.wordpress.com")
@@ -683,7 +694,7 @@ public WebResourceResponse handleRequest(@NonNull WebResourceRequest request) {
                 .appendPath(url.getAuthority())
                 .appendPath("atomic-auth-proxy")
                 .appendPath("file")
-                .appendEncodedPath(url.getPath().substring(1)) // Remove leading '/'
+                .appendEncodedPath(path)
                 .build();
 
         return newUri.toString();