Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

verifyHeader is not an async function #1

Closed
cptchloroplast opened this issue May 19, 2021 · 0 comments
Closed

verifyHeader is not an async function #1

cptchloroplast opened this issue May 19, 2021 · 0 comments

Comments

@cptchloroplast
Copy link

verifyHeader is not an async function in the stripe-node implementation of the webhook.

https://github.com/stripe/stripe-node/blob/0c67cd3ac1baa63ccb751bfbb1dcf964b946fada/lib/Webhooks.js#L70

This can cause an error to be thrown after the request has finished. My suggestion would be to await verifyHeader and make constructEvent an async function as well.
@qwtel qwtel closed this as completed in cd0dead May 24, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cptchloroplast