Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add export checking to windows libraries #2

Open
PeterJohnson opened this issue Aug 10, 2019 · 2 comments
Open

Add export checking to windows libraries #2

PeterJohnson opened this issue Aug 10, 2019 · 2 comments
Assignees
@PeterJohnson

Comments

@PeterJohnson
Copy link
Member

Linux libraries are checked for exports of frc:: symbols, but Windows ones are currently not.
@PeterJohnson PeterJohnson self-assigned this Aug 10, 2019
@jasondaming
Copy link
Member

What is the risk here?

@PeterJohnson
Copy link
Member Author

That the vendor built the Windows libraries such that they statically linked or otherwise override WPILib symbols, which could result in overriding of WPILib behavior/classes and difficult to diagnose issues due to that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@PeterJohnson PeterJohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeterJohnson @jasondaming