Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sessionFilename in wpspider.py no checks #2

Open
fgeek opened this issue Feb 24, 2013 · 4 comments
Open

sessionFilename in wpspider.py no checks #2

fgeek opened this issue Feb 24, 2013 · 4 comments

Comments

@fgeek
Copy link

fgeek commented Feb 24, 2013

Hello,

No checks are done in wpspider.py#L86. This can have very serious impact if someone creates symlink or similar. I understand that this program shouldn't be run with root permissions, but in my opinion this issue should still be fixed just in case.

@gbrindisi
Copy link
Contributor

Hi Henri,
yes I'm aware of the problem (https://github.com/ohpe/wpspider/commit/034a7731f4bc02eab164d460aa2b9b9dff3b0b65#L8R15). The code involved has been added no more than a couple hours ago, anyway the spider is still very alpha.

Hopefully @Ophe will provide a patch.

@ohpe
Copy link
Contributor

ohpe commented Feb 24, 2013

Sure, was a first test (my pre-pre-alpha version), I'll fix asap

@fgeek
Copy link
Author

fgeek commented Oct 2, 2018

Friendly ping @ohpe :)

@ohpe
Copy link
Contributor

ohpe commented Oct 3, 2018

I completely forgot this project. Why don't you file a PR :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants