Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incosistent access modifiers in JDBCUserStoreManager #2474

Open
danijelt opened this issue Dec 13, 2019 · 0 comments
Open

Incosistent access modifiers in JDBCUserStoreManager #2474

danijelt opened this issue Dec 13, 2019 · 0 comments

Comments

@danijelt
Copy link

Description:
JDBCUserStoreManager has incosistent access modifiers in addProperty, addProperties, updateProperty and updateProperties. addProperty is public, updateProperty is protected and add/updateProperties are private.

When writing custom user store manager that inherits JDBCUserStoreManager, if we want to override these 4 methods, we need to fully reimplement them, as well as persistUser, doSetUserClaimValue and doSetUserClaimValues.

Affected Product Version:
WSO2 IS 5.9.0

Steps to reproduce:
Write custom user store that extends JDBCUserStore, try to override addProperty, addProperties, updateProperty and updateProperties. Only addProperty and updateProperty can be overridden.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant