Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename final result file: "optitype_calls.txt" to something more intuitive #72

Closed
malachig opened this issue Oct 27, 2022 · 0 comments · Fixed by #73
Closed

Rename final result file: "optitype_calls.txt" to something more intuitive #72

malachig opened this issue Oct 27, 2022 · 0 comments · Fixed by #73

Comments

@malachig
Copy link
Member

Now that we have class I and II typing from optitype and phlat I believe this name no longer reflects the contents of this file:
hla_typing/optitype_calls.txt

A recent example of this file had these contents:
HLA-A*02:01,HLA-A*01:01,HLA-B*15:17,HLA-B*13:02,HLA-C*06:02,HLA-C*07:01,DQA1*01:02,DQA1*02:01,DQB1*02:02,DQB1*06:09,DRB1*07:01,DRB1*13:02

This is confusing, because optitype only makes ClassI calls. So how can we have all those ClassII alleles here? Presumably these are coming from Phlat as well now?

I believe the file is being created here:
https://github.com/griffithlab/analysis-wdls/blob/50122a2c90285d14a8cf06dddc92134714da2e9c/definitions/tools/hla_consensus.wdl#L185

It seems like maybe that file now contains the consensus of:
hla_typing/phlat_normal_HLA.sum and hla_typing/optitype_normal_result.tsv

The code above, sounds like it will just write out the optitype calls...

But actually now it looks like when we extract HLA alleles, we do so for both Phlat and Optitype. And then pass all of this into the hlaConsensus task:
https://github.com/griffithlab/analysis-wdls/blob/018f5c0721252a57c22435a68123f611612fb7f1/definitions/immuno.wdl#L378-L390

Those inputs in those steps could also be renamed perhaps to be a bit clearer.

@Layth17 Layth17 linked a pull request Oct 27, 2022 that will close this issue
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant