You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we have class I and II typing from optitype and phlat I believe this name no longer reflects the contents of this file: hla_typing/optitype_calls.txt
A recent example of this file had these contents: HLA-A*02:01,HLA-A*01:01,HLA-B*15:17,HLA-B*13:02,HLA-C*06:02,HLA-C*07:01,DQA1*01:02,DQA1*02:01,DQB1*02:02,DQB1*06:09,DRB1*07:01,DRB1*13:02
This is confusing, because optitype only makes ClassI calls. So how can we have all those ClassII alleles here? Presumably these are coming from Phlat as well now?
Now that we have class I and II typing from optitype and phlat I believe this name no longer reflects the contents of this file:
hla_typing/optitype_calls.txt
A recent example of this file had these contents:
HLA-A*02:01,HLA-A*01:01,HLA-B*15:17,HLA-B*13:02,HLA-C*06:02,HLA-C*07:01,DQA1*01:02,DQA1*02:01,DQB1*02:02,DQB1*06:09,DRB1*07:01,DRB1*13:02
This is confusing, because optitype only makes ClassI calls. So how can we have all those ClassII alleles here? Presumably these are coming from Phlat as well now?
I believe the file is being created here:
https://github.com/griffithlab/analysis-wdls/blob/50122a2c90285d14a8cf06dddc92134714da2e9c/definitions/tools/hla_consensus.wdl#L185
It seems like maybe that file now contains the consensus of:
hla_typing/phlat_normal_HLA.sum
andhla_typing/optitype_normal_result.tsv
The code above, sounds like it will just write out the optitype calls...
But actually now it looks like when we extract HLA alleles, we do so for both Phlat and Optitype. And then pass all of this into the hlaConsensus task:
https://github.com/griffithlab/analysis-wdls/blob/018f5c0721252a57c22435a68123f611612fb7f1/definitions/immuno.wdl#L378-L390
Those inputs in those steps could also be renamed perhaps to be a bit clearer.
The text was updated successfully, but these errors were encountered: