Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

approach 2 to issue #29 #52

Merged
merged 2 commits into from
Jul 5, 2022
Merged

approach 2 to issue #29 #52

merged 2 commits into from
Jul 5, 2022

Conversation

Layth17
Copy link
Member

@Layth17 Layth17 commented Jun 20, 2022

Approach 2

@malachig
Copy link
Member

One thing about this solution. What will be the final file name of the result file that is saved? It looks like it might just be a generic name? I think we need some way to make this come out in a way that the end user can clearly distinguish between the tumor and normal optitype results

@malachig
Copy link
Member

Yeah currently in the final result we get normal results here:
hla_typing/optitype_result.tsv

And tumor results at the top level
optitype_result.tsv

Can we instead reorganize the outputs so that these are in:
hla_typing_normal/
hla_typing_tumor/

Copy link
Member

@malachig malachig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested with Layth and the results looked good as well.

@malachig malachig merged commit a287bb4 into wustl-oncology:main Jul 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update immuno.wdl to include a step that runs HLA typing on the tumor exome data
2 participants