Intuitive file/input names #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Layth17
commented
Oct 27, 2022
•
Layth17
commented
- syntax check
- functionality check
added 2 commits
October 26, 2022 23:37
tmooney
approved these changes
Oct 31, 2022
| @@ -182,7 +182,9 @@ task hlaConsensus { | |||
|
|
|||
| #Create an exact copy of optitype calls, to be bundled with other relevant | |||
| #files for convenience/later review. Always generated, | |||
| with open("hla_calls/optitype_calls.txt", "w") as o_c: | |||
| #NOTE(Layth): this hla_consensus step actually gets passed results from | |||
| #Optitype for class I and PHLAT for class II. hla_calls will include both results. | |||
There was a problem hiding this comment.
It might be nice to follow up on this tool and fix some of the existing comments (and the variable name?) to reflect its true contents.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.