Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add localization optional to varscan somatic. #79

Merged

Conversation

tmooney
Copy link
Member

@tmooney tmooney commented Jan 24, 2023

This required building a newer image with varscan and a newer samtools that supports reading gs:// URLs.

There are some differences in the varscan output as a result of this change. The most dramatic change comes not from upgrading to 1.16.1 but from switching from the custom samtools 1.3.1/htslib 1.3.2 combo in the CLE image to any other version I tried (1.3.1 and 1.7). So not sure if there's something special about the combination in the CLE image...

This is part of #64.

Copy link
Member

@chrisamiller chrisamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - Tom and I talked through some of the samtools changes the other day, and it seems like they are all reasonable

@malachig
Copy link
Member

Varscan variant calling seems to be working based on the final outputs.

Copy link
Member

@malachig malachig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tmooney tmooney merged commit f974a8c into wustl-oncology:main Feb 16, 2023
@tmooney tmooney deleted the varscan_somatic_localization_optional branch February 16, 2023 18:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants