New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Using Session.shutdown inside airframe-http endpoint causes deadlock #693

Closed

xerial opened this issue Sep 10, 2019 · 1 comment

Labels

Milestone

Member

xerial commented Sep 10, 2019

This code can cause a deadlock:

@EndPoint(path="/shutdown")
def shutdown : Unit = {  
   session.shutdown   // Blocks because the server cannot be stopped until this returns some response
}

Possible solutions:

Run session.shutdown in a background thread
Force terminating FinagleServer

xerial added this to the Airframe 20 milestone

xerial mentioned this issue

Milestone: Airframe 21 #1375

Closed

90 tasks

xerial modified the milestones: Airframe 20, Airframe 21

exoego added the enhancement label

Member Author

xerial commented Jan 9, 2024

A workaround is running this code in a separate thread.

xerial closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment