Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The action is completed successfully, even when there is an error #101

Closed
samuelcecilio opened this issue Feb 22, 2023 · 5 comments · Fixed by #111
Closed

The action is completed successfully, even when there is an error #101

samuelcecilio opened this issue Feb 22, 2023 · 5 comments · Fixed by #111

Comments

@samuelcecilio
Copy link

Apparently the error code that happens inside the entrypoint is not forwarded to github, so this action always returns success.

This results in a false positive, because to know that something is wrong, I need to go to the workflow and click on the step that is marked as success, but at the end of the log there is an error.

https://docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions#setting-a-failure-exit-code-in-a-docker-container-action

Captura de Tela 2023-02-22 às 11 01 02

@moweb-Vaidehi
Copy link

Same issue happening with me

Screenshot 2023-03-30 at 10 35 28 AM

@amorujao
Copy link

amorujao commented Apr 5, 2023

In my case I was still setting up the project and had an error in the inputs (empty appId) and it also succeeded despite showing an error message in the logs.

@arthurljones
Copy link

This just happened to my team - we changed a build config and that unexpectedly changed the output file.

image

Another action in the script posts a comment on the PR when the build is ready, which still fired, because the upload action reported success despite an error.

@emartynov
Copy link

I assumed it should fail the job. Apparently, it doesn't. Can we fix it?

@JulienDupontDev
Copy link

JulienDupontDev commented Jun 7, 2023

Same here, got "Error: failed to determine AAB info. HTTP Error: 403, Firebase App Distribution API has not been used in project" but job still shows as successful, not very good for CI / CD to not have reports about a failed deployment xD

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants