-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
The action is completed successfully, even when there is an error #101
Comments
In my case I was still setting up the project and had an error in the inputs (empty appId) and it also succeeded despite showing an error message in the logs. |
I assumed it should fail the job. Apparently, it doesn't. Can we fix it? |
Same here, got "Error: failed to determine AAB info. HTTP Error: 403, Firebase App Distribution API has not been used in project" but job still shows as successful, not very good for CI / CD to not have reports about a failed deployment xD |
Apparently the error code that happens inside the entrypoint is not forwarded to github, so this action always returns success.
This results in a false positive, because to know that something is wrong, I need to go to the workflow and click on the step that is marked as success, but at the end of the log there is an error.
https://docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions#setting-a-failure-exit-code-in-a-docker-container-action
The text was updated successfully, but these errors were encountered: