Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce requirements for interpolation, bias correction & outlier removal #89

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

ayushpatnaikgit
Copy link
Member

We weren't cleaning pixels with more than 50% missing values. I propose reducing this constraint to 90%.

Some functions like fit(SmoothingSpline, ... ) may not work with too many missing observations. We will need to test this by creating artificial missing values.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #89 (59d01ab) into main (72839cf) will decrease coverage by 1.16%.
The diff coverage is 100.00%.

❗ Current head 59d01ab differs from pull request most recent head c7d09cd. Consider uploading reports for the commit c7d09cd to get more accurate results

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   96.81%   95.65%   -1.16%     
==========================================
  Files          14       14              
  Lines         345      345              
==========================================
- Hits          334      330       -4     
- Misses         11       15       +4     
Impacted Files Coverage Δ
src/data_cleaning/bias_correction.jl 97.14% <100.00%> (ø)
src/data_cleaning/interpolation.jl 80.76% <100.00%> (-15.39%) ⬇️
src/data_cleaning/outlier_removal.jl 93.93% <100.00%> (ø)

@ayushpatnaikgit ayushpatnaikgit merged commit 21b8561 into xKDR:main Jul 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants