Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update our LLVM toolchain #6921

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

grendello
Copy link
Contributor

Changes: (LLVM) https://discourse.llvm.org/t/llvm-14-0-1-release/61700

Updates LLVM version to just-relased version 14.0.1 and now includes
Windows PDB files in the distribution.

@grendello grendello requested review from pjcollins and jonpryor April 13, 2022 17:38
@jonpryor
Copy link
Member

Context: #6921

@pjcollins
Copy link
Member

Could we also add a couple of yaml steps that will copy/link the pdb files to a staging directory and then upload them as a pipeline artifact? These new steps should probably go in the mac build job here: https://github.com/xamarin/xamarin-android/blob/d2f82062d294f9772a7e96753a3e4bbf7cbd4088/build-tools/automation/azure-pipelines.yaml#L115

An example of this can be found here: https://github.com/xamarin/xamarin-android/blob/d2f82062d294f9772a7e96753a3e4bbf7cbd4088/build-tools/automation/azure-pipelines.yaml#L314-L328

@grendello grendello force-pushed the bump-llvm-toolchain branch from d231c47 to 84ccad3 Compare April 13, 2022 19:19
@grendello
Copy link
Contributor Author

@pjcollins pushed the requested YAML update, can you take a look if it's fine?

Changes: (LLVM) https://discourse.llvm.org/t/llvm-14-0-1-release/61700

Updates LLVM version to just-relased version 14.0.1 and now includes
Windows PDB files in the distribution.
@grendello grendello force-pushed the bump-llvm-toolchain branch from 84ccad3 to 4477103 Compare April 13, 2022 20:05
@jonpryor
Copy link
Member

jonpryor commented Apr 15, 2022

WIP commit message for review:

Bump to xamarin/xamarin-android-binutils/L_14.0.1-4.1.0@b1426f5d

Context: https://discourse.llvm.org/t/llvm-14-0-1-release/61700

Changes: https://github.com/xamarin/xamarin-android-binutils/compare/L_13.0.1-4.0.1...L_14.0.1-4.1.0

  * xamarin/xamarin-android-binutils@b1426f5: [Linux] Try to build with g++ 10, as the default one fails for libLLVMLTO
  * xamarin/xamarin-android-binutils@d15538b: Update for 14.0.1 changes
  * xamarin/xamarin-android-binutils@7d64169: Bump LLVM to 14.0.1
  * xamarin/xamarin-android-binutils@21248f0: Package .pdb files
  * xamarin/xamarin-android-binutils@b64d6d4: Attempt no 2 to enable PDB
  * xamarin/xamarin-android-binutils@c2ade3b: [Windows] build Release LLVM with debug info

Update to use LLVM 14.0.1.

The new `xamarin-android-toolchain-L_14.0.1-4.1.0.7z` archive now
includes `.pdb` files for the Windows toolchain.

The new **copy Windows toolchain pdb files** CI step copies the
`.pdb` files into a `windows-toolchain-pdb` artifact.
The [VS release pipeline][0] will be updated to download this new
`windows-toolchain-pdb` artifact and send it to the symbol server.

Co-authored-by: Peter Collins <pecolli@microsoft.com>

[0]: https://dev.azure.com/devdiv/DevDiv/_release?_a=releases&view=mine&definitionId=3249

@jonpryor jonpryor merged commit 16bbf6f into dotnet:main Apr 15, 2022
@grendello grendello deleted the bump-llvm-toolchain branch April 19, 2022 07:25
pjcollins added a commit that referenced this pull request Apr 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants