Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[D3D12] RTV pipeline creation: depth_bias_slope_scaled - memory leak/performance issue #2253

Open
7 tasks done
Gliniak opened this issue Mar 16, 2024 · 0 comments
Open
7 tasks done

Comments

@Gliniak
Copy link
Member

Gliniak commented Mar 16, 2024

Validation

Describe what's going wrong

GetCurrentStateDescription in pipeline_cache.cc creates PipelineRuntimeDescription which in case of RTV uses GetPreferredFacePolygonOffset to generate depth_bias_slope_scaled.
This is a problem because for some calls this is executed with different register values which causes to generate multiple pipelines for the same shader that will never be use again.

Test cases: xenia-project/game-compatibility#52
xenia-project/game-compatibility#21

In case of first test case values (from registers) are quite small: 0.0001 - 0.0000001
For second one they're quite huge: 10-150

Describe what should happen

No idea

If applicable, provide a callstack here, especially for crashes

No response

If applicable, upload a logfile and link it here

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants