Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SR creation in need of cleanups #31

Open
ydirson opened this issue Jan 4, 2023 · 0 comments
Open

SR creation in need of cleanups #31

ydirson opened this issue Jan 4, 2023 · 0 comments

Comments

@ydirson
Copy link
Contributor

ydirson commented Jan 4, 2023

Digging into initial SR creation, I find a couple of inconsistencies, not all of which are obvious to get straight:

  • default-storage.conf gets written both XSPARTITIONS/XSTYPE and PARTITIONS/TYPE, with backend.py saying the latter are legacy names. It would appear that scripts on a newly installed system will use non-legacy names and have no need for legacy ones, so probably we could remove legacy names. However storage-init does use PARTITIONS/TYPE. Something looks wrong :)
  • backend.py points to prepare-storage as user of this file, while the user is clearly storage-init

@rosslagerwall, those XS names were introduced in 2008, is this some transition that did not make it into sm ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant