This repository has been archived by the owner on Mar 8, 2019. It is now read-only.
'src' attribute check method accepts data URL #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified regular expression to match data URL for images encoded to base64. Fixes this [issue 334](#334)
|
This seem like a useful feature. I'm just not sure about it being on "src" since the point of whitelisting is to prevent people from being able to do things like It looks like the tests for these live in test/dom/parse_test.js, which should be updated to verify this functionality. |
|
Yeah, you may be right. But, is there a way to do so? Write another method like 'image_src' to allow data URLs only for images? About the tests, do you mean "Check custom data attributes"? Unfortunately, these are for HTML5 'data-' attributes, not for data URLs. |
|
Is this project somehow... dead? No response from original author for almost 2 months. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified regular expression to match data URL for images encoded to base64.
Fixes issue 334