Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Styling of popovers breaks with latest antd version #1

Closed
jpreis opened this issue Sep 10, 2020 · 2 comments
Closed

Styling of popovers breaks with latest antd version #1

jpreis opened this issue Sep 10, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jpreis
Copy link

jpreis commented Sep 10, 2020

Describe the bug
When using react-js-cron in conjunction with the latest version of antd (4.6.3 as of writing this), the styling of popovers is broken (the entries aren't shown in a grid). The package.json only specifices >=4.1.0 as the version for this peer dependency. This problem doesn't arise when using antd 4.2.5.

To Reproduce
Codesandbox: https://codesandbox.io/s/reat-js-cron-5chdk

Steps to reproduce the behavior:
Click on any dropdown

Expected behavior
Items in the popover should be displayed in a grid.

Screenshots
With antd 4.6.3:
latest

With antd 4.2.5:
4_2_5

Additional context
The layout breaks since there is an extraneous div inside the grid container instead of the grid-items. Somehow the way the items are rendered within the popover has changed between these two versions (seeing the additional rc-virtual-list classes that are present when using 4.6.3).

@xrutayisire
Copy link
Owner

Hi,

Thanks for the report 👍
I will investigate the problem and try to make a fix.

@xrutayisire
Copy link
Owner

This issue has been fixed with react-js-cron version 1.1.0.

Thanks a lot for finding this bug and let me know if there is something else that cause a problem now.

Be sure to read the changelog before using new version 😉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants