Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Diagram links not showing until page is refreshed, after editing a page with a diagram macro #269

Open
ane-gabriela opened this issue May 27, 2024 · 2 comments

Comments

@ane-gabriela
Copy link

ane-gabriela commented May 27, 2024

Steps to reproduce:

  1. Create a diagram "Diagram-1"

  2. Add some shapes

  3. In one or 2 of the shapes add some text

  4. Select a word and link it to another page in the wiki

  5. Select another word and link it to an external URL
    DiagramWithLinks

  6. Create a new simple page

  7. Edit it and click on Insert > Other Macros

  8. Search for Diagram Macro

  9. In the "Reference" Field type the name of the existing diagram page (e.g. Diagram.Diagram-1.WebHome)

  10. Uncheck "Cached"

  11. Click Submit

  12. Click on Save & View

Expected results: The diagram appears with the selected links.

Actual results: The diagram appears with no links, the user needs to refresh the page 1or 2 times to see the links.

After Save & View
ResultDiagram1

After Refresh
AfterRefreshDiagram

Environment: Windows 11, Chrome 125, Cloud XWiki 15.10.8, Diagram Application (Pro) 1.20.4

@snazare snazare removed their assignment Jun 6, 2024
@oanalavinia oanalavinia self-assigned this Jun 10, 2024
@oanalavinia oanalavinia changed the title Links not showing until the page is refreshed, when displaying a diagram on a different page Links not showing until the page is refreshed, when using the diagram macro Jun 18, 2024
@oanalavinia oanalavinia changed the title Links not showing until the page is refreshed, when using the diagram macro Diagram links not showing until page is refreshed, after editing a page with a diagram macro Jun 18, 2024
@oanalavinia oanalavinia moved this from Todo to In Progress in ProAppsRoadmapJune-July2024 Jun 18, 2024
@oanalavinia
Copy link

This happens only when using inline editing mode, and it's not only for the first time you add a diagram macro (that links to a diagram with links), but every time you inline edit a page with such diagrams. Basically, the view you had in edit mode, with a diagram image instead of the actual diagram, is preserved until you refresh the page.
From what I understand, this is the expected behavior, since inline editing tries to transition from edit to view smoothly.
@mflorea can you confirm this is the expected behavior, or should I look more into it?

@ane-gabriela
Copy link
Author

ane-gabriela commented Nov 21, 2024

Issue reproducing on XWiki 14.10.18 with Diagram version 1.21.1-rc-1, Chrome 131, Windows 11 Pro

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants