Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Ensure that previewed changes apply on get_pages filter #241

Closed
3 of 4 tasks
westonruter opened this issue Sep 2, 2016 · 0 comments
Closed
3 of 4 tasks

Ensure that previewed changes apply on get_pages filter #241

westonruter opened this issue Sep 2, 2016 · 0 comments
Assignees
Milestone

Comments

@westonruter
Copy link
Contributor

westonruter commented Sep 2, 2016

The call to get_pages() may be (rightly) cached because it is used to build an entire tree of all posts. However, because the value may be cached, it will not respected the current customized state, besides the fact that it doesn't use WP_Query to begin with.

  • Call \WP_Customize_Posts_Preview::preview_setup_postdata() on each of the items in the get_pages filter.
  • Ensure that newly-added pages are included and appear in the right sort order.
  • Ensure newly added posts via nav menus are included (the auto-drafts among nav_menus_created_posts). See Ensure that post/page stubs created for nav menu items in WP4.7 can be edited #253.
  • Beware of the $args for get_pages (other than post_type) and how get_pages would need to get re-applied. We have to initially support (per page_attributes_meta_box): post_type, exclude_tree, sort_column.

This is a dependency for #65

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant