Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add way to cleanup liilGui and stats.js #208

Open
remcoder opened this issue Oct 4, 2024 · 1 comment
Open

Add way to cleanup liilGui and stats.js #208

remcoder opened this issue Oct 4, 2024 · 1 comment

Comments

@remcoder
Copy link
Member

remcoder commented Oct 4, 2024

When creating a new instance of GCodePreview to replace the old, like when showing a different file, some (DOM) state should be cleaned up. Currently, stats.js and lilGui don't have have a proper way of disposing. (in the new vue demo there are some hacks for this)

Even when we're not creating a new instance, like when the user navigates away in a SPA, the whole GCodePreview, including lilGui and stats needs to be disposed.

@remcoder
Copy link
Member Author

We are refining the init/dispose cycle in 3.0 so to avoid rework let's move this to 3.0

@remcoder remcoder added 3.0 and removed 2.x Issues and pull-request aimed for v2.x labels Oct 18, 2024
@sophiedeziel sophiedeziel added this to the 3.0-alpha2 milestone Oct 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants