Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move the drag and drop code #231

Open
sophiedeziel opened this issue Oct 16, 2024 · 3 comments · May be fixed by #284
Open

Move the drag and drop code #231

sophiedeziel opened this issue Oct 16, 2024 · 3 comments · May be fixed by #284

Comments

@sophiedeziel
Copy link
Collaborator

Should we un-deprecate the drag and drop option?

The _enableDropHandler() method could be moved outside of WebGLPreview.

@remcoder
Copy link
Member

I'd be for undeprecating DnD. We could probably use something like a a dom-utils module or canvas wrapper class to organize things like DnD and resizing.

@remcoder
Copy link
Member

remcoder commented Jan 14, 2025

petition to rename 'allowDragNDrop' to dnd. So you can just set the option dnd : true..

or another option: droppable: true.

@sophiedeziel
Copy link
Collaborator Author

I vote droppable!

I'm not a fan of using acronyms in APIs, unless documentation is using the long form. The thing is, even when an acronym is widely known, someone may need to google it to know what it means. I18n is easy to find the meaning for, but dnd could mean a lot of things.

@remcoder remcoder linked a pull request Jan 27, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants