Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tests failing on windows in a fresh fork #35

Closed
johannao76 opened this issue Jun 1, 2018 · 5 comments
Closed

Tests failing on windows in a fresh fork #35

johannao76 opened this issue Jun 1, 2018 · 5 comments
Assignees

Comments

@johannao76
Copy link

johannao76 commented Jun 1, 2018

I forked the repo just now and getting an error when running npm test. I am using node 8.9.4. Full test run output below:
image

@xz64
Copy link
Owner

xz64 commented Jun 2, 2018

From the screenshot it appears you might be on Windows.

Unit tests don't run properly on Windows. I had tried to make it work but ran into some issue with mock-fs : tschaub/mock-fs#201

Next major release (you can try it out by installing license-webpack-plugin@next) should be able to run on windows but I haven't tested it.

@johannao76 johannao76 changed the title Tests failing in a fresh fork Tests failing on windows in a fresh fork Jun 4, 2018
@xz64
Copy link
Owner

xz64 commented Jun 5, 2018

@johannao76 If you don't mind, can you check out the dev branch and see if the tests work from windows?

@johannao76
Copy link
Author

I will try to get to it this weekend.

@johannao76
Copy link
Author

johannao76 commented Jun 17, 2018

I checked out the dev branch but I am unable to build at all:
image

Looks like the problem is the single quotes, changing to double quotes addresses the issue. There is also a warning during linting:
Warning: The 'no-boolean-literal-compare' rule requires type information.

I fixed this by adding --project tsconfig.json to the tslint command, the following addresses both issues. BTW, the tests now work on Windows, thanks for fixing!

image

@xz64
Copy link
Owner

xz64 commented Jul 6, 2018

I pushed changes to the dev branch to resolve the issue. (using cross-env)

@xz64 xz64 self-assigned this Jul 6, 2018
@xz64 xz64 closed this as completed Jul 6, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants