Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Glitched rendering table of PDF by exported in v0.0.9 #101

Closed
yhatt opened this issue Oct 8, 2016 · 7 comments · Fixed by #114
Closed

Glitched rendering table of PDF by exported in v0.0.9 #101

yhatt opened this issue Oct 8, 2016 · 7 comments · Fixed by #114
Labels
Milestone

Comments

@yhatt
Copy link
Owner

yhatt commented Oct 8, 2016

In v0.0.9, rendering table in exported PDF have a glitch.
This glitch is not occured in preview pane. It only has in PDF.

example-exported-in-v0.0.9.pdf

Glitched page

Duplicated table header ⬇️

glitched_page

@yhatt yhatt added the bug label Oct 8, 2016
@yhatt yhatt added this to the v0.0.9.1 milestone Oct 8, 2016
@yhatt
Copy link
Owner Author

yhatt commented Oct 8, 2016

I made markdown for testing this issue:

# First page

---

|Table 1|
|:---:|
|Test table|

|Table 2|
|:---|
|Test table|

|Table 3|
|---:|
|Test table|

The table header duplication will occur in after second page.

test.pdf

@yhatt
Copy link
Owner Author

yhatt commented Oct 8, 2016

Reported Chromium bug tracker, and already fixed in Chromium 54: https://bugs.chromium.org/p/chromium/issues/detail?id=631222

We should wait update of Electron, included Chromium 54 (perhaps Electron 1.5.x).

@wangruohui
Copy link

Does it mean that this problem can not be solved at this stage before Electron is updated?

@yhatt
Copy link
Owner Author

yhatt commented Nov 1, 2016

Yes, Marp cannot affect Electron's PDF rendering.

Luckily Electron 1.3.8 (Chromium 52 and it have not a glitch) had updated as the latest release. Marp is not using 1.4.x new features currently.

Perhaps the current best way to fix may update Electron to 1.3.8.

@wangruohui
Copy link

Thanks for your reply. But I am still a little bit confusing about the Electron. Should I install it stand alone or it is already included in the release of marp? Does marp require external software (such as Electron or others) to render the PDF? As I didn't have either Chromium or Electron installed on my computer, but I can still get the PDF generated.

@yhatt
Copy link
Owner Author

yhatt commented Nov 1, 2016

Electron has already included in the release of Marp. You don't have to install external software (unless you are Marp developer).

@yhatt
Copy link
Owner Author

yhatt commented Nov 6, 2016

Temporarily we rollbacked to Electron. We will update when Electron 1.5.x is released

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants