Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rendering not in body #232

Open
lishine opened this issue Dec 16, 2020 · 4 comments
Open

Rendering not in body #232

lishine opened this issue Dec 16, 2020 · 4 comments

Comments

@lishine
Copy link

lishine commented Dec 16, 2020

Hi,

My application is embedded (not iframe), I want to render the popup-root under the application root.
Another problem that I see is that popup-content has element styles which I cannot override.

@SimplyComplexable
Copy link
Contributor

@yjose Is this possible? I found a PR to implement this from a couple years ago that was rejected, but 2.0 updated to Portals. Seems like this should be more easily possible now? I can work on PR if it would help.

@SimplyComplexable
Copy link
Contributor

@lishine I looked through the source and you can see here that if you add an element to with an id of popup-root it will render into that element. I tested this for my situation and it worked perfect!

@yjose
Copy link
Owner

yjose commented Jan 29, 2021

@SimplyComplexable can you add it somewhere in the docs

@SimplyComplexable
Copy link
Contributor

@yjose I created PR #239 let me know if you want any updates.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants