Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The getContent method references the method getXmlElement which does not appear to exist. #86

Open
1 task done
chanced opened this issue Oct 23, 2021 — with Huly for GitHub · 1 comment
Open
1 task done

The getContent method references the method getXmlElement which does not appear to exist. #86

chanced opened this issue Oct 23, 2021 — with Huly for GitHub · 1 comment
Assignees
@dmonad
Labels
bug Something isn't working

Comments

@chanced Huly for GitHub
Copy link

chanced commented Oct 23, 2021 •
edited by dmonad
Loading

Checklist

  • Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/

Describe the bug

the function getContent references getXmlElement on a Y.Doc which does not appear to exist.

y-websocket/bin/callback.js

Line 73 in caa6304

case 'XmlElement': return doc.getXmlElement(objName)

https://github.com/yjs/yjs/blob/dc9717ecd0650315d87129cff795dc5116f8bcf2/src/utils/Doc.js

To Reproduce I'm not sure that code branch can ever be reached but I wanted to let you know regardless.

Environment Information

  • y.js 13.5.6 per y-websocket's dependency
  • y-websocket - latest

Huly®: YJS-512
@chanced chanced added the bug Something isn't working label Oct 23, 2021
@dmonad
Copy link
Member

dmonad commented Nov 22, 2021

Right, thanks! We should adopt this to ydoc.get(objName, Y.XmlElement).

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dmonad dmonad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chanced @dmonad