Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exception/crash when sending garbage to websocket #95

Open
2 tasks done
szborows opened this issue Feb 8, 2022 · 0 comments
Open
2 tasks done

Exception/crash when sending garbage to websocket #95

szborows opened this issue Feb 8, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@szborows
Copy link

szborows commented Feb 8, 2022

Please save me some time and use the following template. In 90% of all issues I can't reproduce the problem because I don't know what exactly you are doing, in which environment, or which y-* version is responsible. Just use the following template even if you think the problem is obvious.

Checklist

Describe the bug
One can crash y-websocker server by sending over wire number greater than 2*2**31.

To Reproduce

  1. start the server: node ./front/node_modules/y-websocket/bin/server.js
  2. open websocket connection: websocat ws://localhost:1234
  3. send 4294967296 (confirm with newline)
  4. send 4294967297

Expected behavior
No exceptions and no crash.

Environment Information

  • node version 17.3.0
  • y-websocket version 1.3.18

Additional context
Idk whether this is problem related to ws or y-websocket. Unfortunately I currently have no time to investigate it further. I'm reporting just in case I forget about it in future.

BTW I suppose y-websocket isn't production-grade software right now, but maybe we can at least not crash whole server upon receiving garbage.

And obligatorily: much thanks for your work!!

@szborows szborows added the bug Something isn't working label Feb 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants