Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing machinery for frontend-specific deprecated field names #2647

Closed
neutrinoceros opened this issue Jun 19, 2020 · 2 comments
Closed

Missing machinery for frontend-specific deprecated field names #2647

neutrinoceros opened this issue Jun 19, 2020 · 2 comments
Labels
deprecation deprecate features or remove deprecated ones new feature Something fun and new! wishlist Things we'd like to do some day

Comments

@neutrinoceros
Copy link
Member

Report

In the discussion around #2613, @brittonsmith proposed that we add a mechanism to attach deprecated field names to specific frontends. Currently all deprecated field names are stored in yt/fields/field_aliases.py.

It seems likely to me that all field names collected in this file are in fact meant to support a specific frontend, and maybe it they can be traced back with git blame.
@neutrinoceros neutrinoceros added wishlist Things we'd like to do some day new feature Something fun and new! labels Jun 19, 2020
@neutrinoceros neutrinoceros added the deprecation deprecate features or remove deprecated ones label Jan 24, 2021
@neutrinoceros
Copy link
Member Author

Note that the new yt/_maintenance/deprecation.py module should be home to any internal functions and classes this would require.

@neutrinoceros neutrinoceros mentioned this issue Feb 5, 2021
Merged
2 tasks
@neutrinoceros
Copy link
Member Author

I believe this was fixed in #3059

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
deprecation deprecate features or remove deprecated ones new feature Something fun and new! wishlist Things we'd like to do some day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neutrinoceros