Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show correct labels for YQL errors #749

Open
Krock21 opened this issue Sep 2, 2024 · 2 comments
Open

Show correct labels for YQL errors #749

Krock21 opened this issue Sep 2, 2024 · 2 comments
Labels
query-tracker All related to Queries page

Comments

@Krock21
Copy link
Member

Krock21 commented Sep 2, 2024

Sometimes it is hard to understand YQL errors. Sometimes they are misleading. For example:
Screenshot 2024-09-02 at 13 12 11
Screenshot 2024-09-02 at 13 12 18

Here we have an error DQ cannot execute the query, which is more like a warning and is misleading. Also it wasn't hidden (1st screenshot) as it is a separate branch.

But in the get_query response we see that the error has some attributes about severity

"inner_errors": [
                            {
                                "code": 31070,
                                "message": "Optimization",
                                "attributes": {
                                    "yql_status": "Core optimization",
                                    "severity": "Info"                                 ===========================================
                                },
                                "inner_errors": [
                                    {
                                        "code": 30000,
                                        "message": "DQ cannot execute the query. Cause: system python udf",
                                        "attributes": {
                                            "yql_status": "Default error",
                                            "severity": "Info"                       ============================================
                                        }
                                    }
                                ]
                            },
                            {
                                "code": 31060,
                                "message": "Execution",
                                "attributes": {
                                    "yql_status": "Core exec",
                                    "severity": "Error"                             =========================================
                                },
                                "inner_errors": [
                                    {
                                        "code": 30000,
                                        "message": "Execution of node: Result",
                                        "attributes": {
                                            "yql_status": "Default error",
                                            "end_position": {
                                                "column": 1,
                                                "row": 7
                                            },
                                            "severity": "Error",                ====================================================
                                            "start_position": {
                                                "column": 1,
                                                "row": 7
                                            }
                                        },

But on the screenshots above, all lines are marked as Error, while Core optimization and DQ cannot execute the query. Cause: system python udf should be marked as Info.

So I suggest:

  • Parse severity and show correct severity for lines
  • Improve error folding by folding everything that is not Error severity
@ma-efremoff ma-efremoff added the query-tracker All related to Queries page label Sep 4, 2024
@vrozaev
Copy link
Collaborator

vrozaev commented Sep 20, 2024

SIG UI Weekly discusssion:

  1. Change "Info" appearance - it should be different from "Error".
  2. In text editor we should try to change color for "Info" from red to another color (blue?)
  3. Do not expand "Info" nodes - user can open them manually via click.

@vrozaev
Copy link
Collaborator

vrozaev commented Nov 1, 2024

@SimbiozizV any news here?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
query-tracker All related to Queries page
Projects
None yet
Development

No branches or pull requests

3 participants