Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Browsers can't open IPv6 addrs #42

Closed
ahmetb opened this issue Aug 23, 2015 · 5 comments
Closed

Browsers can't open IPv6 addrs #42

ahmetb opened this issue Aug 23, 2015 · 5 comments
Labels
Milestone

Comments

@ahmetb
Copy link

ahmetb commented Aug 23, 2015

➜  ~  gotty -w top
2015/08/23 12:20:01 Server is starting with command: top
2015/08/23 12:20:01 URL: http://::1:8080/
2015/08/23 12:20:01 URL: http://127.0.0.1:8080/
2015/08/23 12:20:01 URL: http://fe80::1:8080/
2015/08/23 12:20:01 URL: http://fe80::a65e:60ff:fecc:5cc7:8080/
2015/08/23 12:20:01 URL: http://192.168.0.113:8080/
2015/08/23 12:20:01 URL: http://fe80::6048:20ff:fea9:ec6f:8080/
2015/08/23 12:20:01 URL: http://192.168.99.1:8080/

From what observe on Chrome and Safari on OS X is browsers can't open addrs like http://::1:8080/ or http://fe80::a65e:60ff:fecc:5cc7:8080/ at all. Maybe the program should just print IPv4 ones?

@yudai yudai added the kind/bug label Aug 23, 2015
@yudai yudai added this to the v0.1.0 milestone Aug 23, 2015
@yudai yudai added the complete label Aug 23, 2015
@yudai
Copy link
Owner

yudai commented Aug 23, 2015

Thank you for the report.
I realized browsers cannot open IPv6 addresses without the delimiters ([ and ]).
Now it shows URLs with the delimiters and you can open them on your browser.

@ahmetb
Copy link
Author

ahmetb commented Aug 23, 2015

@yudai left a comment at 5d2cdd2

also you should probably mention issue numbers (#nn) in the commit messages so that it would be easy to track/associate.

@yudai
Copy link
Owner

yudai commented Aug 23, 2015

@ahmetalpbalkan Thanks! Replaced the logic with net.JoinHostPort.
Yeah, I often forget to add #nn in commits :)

@ahmetb
Copy link
Author

ahmetb commented Aug 23, 2015

@yudai yeah you can even close issues automatically with commits including Fixes #42 somewhere within the commit msg :)

@ahmetb ahmetb closed this as completed Aug 23, 2015
@NatoBoram
Copy link

Looks like this issue was closed 4 years ago, but I just reinstalled gotty and I still have this issue.

2019/02/17 17:00:09 Alternative URL: http://fe80::6631:50ff:fe5b:b589:5916/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants