Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove bsddb3 #1464

Closed
d-v-b opened this issue Jul 14, 2023 · 3 comments
Closed

remove bsddb3 #1464

d-v-b opened this issue Jul 14, 2023 · 3 comments
Labels
maintenance Work needed by a maintainer

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Jul 14, 2023

We have tests that attempt to import bsddb3. I couldn't run these tests because I could not get bsddb3 to install (because the project is dead). The bsddb3 project page recommends using the berkeleydb, but I couldn't get that to install either (on my m2 mac).

It seems that, at a minimum, we should remove any attempt to import bsddb3, since it's dead. What should we replace it with, if anything?

@jakirkham
Copy link
Member

Looking at the packaging situation, it appears there is a bsddb3 package in conda-forge, which are built for several OSes & architectures including macOS ARM. There is also discussion about adding berkeleydb to conda-forge. Don't see wheels for either

There were several of these added a while back in PR ( #186 ), which are all pretty similar

Maybe it would be worth refactoring out one class that could handle any flavor of these (maybe taking an open function to use). Then we could keep the handful that are useful / testable and then point users wanting anything else to the refactored class. WDYT?

@jakirkham jakirkham added the maintenance Work needed by a maintainer label Jul 15, 2023
@joshmoore
Copy link
Member

No objections to the refactoring, though it'd suggest a deprecation cycle.

Additional option would be to extract the class. My proposal for how to start on that if someone is interested is in https://github.com/zarr-developers/cookiecutter-zarr-store

@dstansby
Copy link
Contributor

See #904 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
maintenance Work needed by a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants