From 21dbe898f1659fba231773f98dfd22ec506410f3 Mon Sep 17 00:00:00 2001
From: Naman Jain <54635559+njain2208@users.noreply.github.com>
Date: Wed, 29 Nov 2023 16:26:40 -0600
Subject: [PATCH] flaky fixes in the project

---
 .../morpheus/array/ArrayBuilderTests.java     | 21 ++++++++++++-----
 .../morpheus/array/ArrayMappedTests.java      |  5 ++--
 .../morpheus/array/ArraysBasicTests.java      | 23 +++++++++++--------
 3 files changed, 31 insertions(+), 18 deletions(-)

diff --git a/src/test/java/com/zavtech/morpheus/array/ArrayBuilderTests.java b/src/test/java/com/zavtech/morpheus/array/ArrayBuilderTests.java
index 09e577d..6308fab 100644
--- a/src/test/java/com/zavtech/morpheus/array/ArrayBuilderTests.java
+++ b/src/test/java/com/zavtech/morpheus/array/ArrayBuilderTests.java
@@ -21,6 +21,7 @@
 import java.time.Month;
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
+import java.time.temporal.ChronoUnit;
 import java.util.Calendar;
 import java.util.Currency;
 import java.util.Date;
@@ -349,11 +350,11 @@ public void testWithLocalDateTimes(int initialSize) {
         Assert.assertEquals(actual.length(), expected.length, "The lengths match");
         Assert.assertEquals(actual.typeCode(), ArrayType.LOCAL_DATETIME, "The array type is as expected");
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(actual.getValue(i), expected[i], "The values match at " + i);
+            Assert.assertEquals(actual.getValue(i), expected[i].truncatedTo(ChronoUnit.MILLIS), "The values match at " + i);
         }
         final Array<LocalDateTime> collected = Stream.of(expected).collect(ArrayUtils.toArray(expected.length));
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(collected.getValue(i), expected[i], "The values match at " + i);
+            Assert.assertEquals(collected.getValue(i), expected[i].truncatedTo(ChronoUnit.MILLIS), "The values match at " + i);
         }
     }
 
@@ -370,11 +371,11 @@ public void testWithZonedDateTimes(int initialSize) {
         Assert.assertEquals(actual.length(), expected.length, "The lengths match");
         Assert.assertEquals(actual.typeCode(), ArrayType.ZONED_DATETIME, "The array type is as expected");
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(actual.getValue(i), expected[i], "The values match at " + i);
+            Assert.assertEquals(actual.getValue(i), expected[i].truncatedTo(ChronoUnit.MILLIS), "The values match at " + i);
         }
         final Array<ZonedDateTime> collected = Stream.of(expected).collect(ArrayUtils.toArray(expected.length));
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(collected.getValue(i), expected[i], "The values match at " + i);
+            Assert.assertEquals(collected.getValue(i), expected[i].truncatedTo(ChronoUnit.MILLIS), "The values match at " + i);
         }
     }
 
@@ -408,11 +409,19 @@ public void testWithMixedTypes(int initialSize) {
         Assert.assertEquals(actual.length(), expected.length, "The lengths match");
         Assert.assertEquals(actual.typeCode(), ArrayType.OBJECT, "The array type is as expected");
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(actual.getValue(i), expected[i], "The values match at " + i);
+             Object frmtValue = expected[i];
+            if(expected[i].getClass().getName() == "java.time.ZonedDateTime"){
+                frmtValue = ((ZonedDateTime) frmtValue).truncatedTo(ChronoUnit.MILLIS);
+            }
+            Assert.assertEquals(actual.getValue(i),frmtValue, "The values match at " + i);
         }
         final Array<Object> collected = Stream.of(expected).collect(ArrayUtils.toArray(expected.length));
         for (int i=0; i<expected.length; ++i) {
-            Assert.assertEquals(collected.getValue(i), expected[i], "The values match at " + i);
+            Object frmtValue = expected[i];
+            if(expected[i].getClass().getName() == "java.time.ZonedDateTime"){
+                frmtValue = ((ZonedDateTime) frmtValue).truncatedTo(ChronoUnit.MILLIS);
+            }
+            Assert.assertEquals(collected.getValue(i), frmtValue, "The values match at " + i);
         }
     }
 
diff --git a/src/test/java/com/zavtech/morpheus/array/ArrayMappedTests.java b/src/test/java/com/zavtech/morpheus/array/ArrayMappedTests.java
index 45a3d04..a827891 100644
--- a/src/test/java/com/zavtech/morpheus/array/ArrayMappedTests.java
+++ b/src/test/java/com/zavtech/morpheus/array/ArrayMappedTests.java
@@ -18,6 +18,7 @@
 
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
+import java.time.temporal.ChronoUnit;
 import java.util.Random;
 
 import org.testng.Assert;
@@ -92,8 +93,8 @@ public void testZonedDateTime() {
             array2[i] = value;
         }
         for (int i=0; i<count; ++i) {
-            final ZonedDateTime v1 = array1.getValue(i);
-            final ZonedDateTime v2 = array2[i];
+            final ZonedDateTime v1 = array1.getValue(i).truncatedTo(ChronoUnit.MILLIS);
+            final ZonedDateTime v2 = array2[i].truncatedTo(ChronoUnit.MILLIS);
             Assert.assertEquals(v1, v2);
             System.out.println(v1);
         }
diff --git a/src/test/java/com/zavtech/morpheus/array/ArraysBasicTests.java b/src/test/java/com/zavtech/morpheus/array/ArraysBasicTests.java
index c01c297..4fc67ef 100644
--- a/src/test/java/com/zavtech/morpheus/array/ArraysBasicTests.java
+++ b/src/test/java/com/zavtech/morpheus/array/ArraysBasicTests.java
@@ -21,6 +21,7 @@
 import java.time.Month;
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
+import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Currency;
@@ -604,14 +605,14 @@ public void testLocalDateTimeArray(boolean sparse) {
             array.setValue(i, value);
         }
         for (int i=0; i<values.length; ++i) {
-            final LocalDateTime v1 = values[i];
+            final LocalDateTime v1 = values[i].truncatedTo(ChronoUnit.MILLIS);
             final LocalDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
         array.expand(200);
         Assert.assertEquals(array.length(), 200, "The array was expanded");
         for (int i=0; i<values.length; ++i) {
-            final LocalDateTime v1 = values[i];
+            final LocalDateTime v1 = values[i].truncatedTo(ChronoUnit.MILLIS);
             final LocalDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
@@ -625,7 +626,7 @@ public void testLocalDateTimeArray(boolean sparse) {
             array.setValue(i, value);
         }
         for (int i=100; i<200; ++i) {
-            final LocalDateTime v1 = values[i-100];
+            final LocalDateTime v1 = values[i-100].truncatedTo(ChronoUnit.MILLIS);
             final LocalDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
@@ -650,14 +651,14 @@ public void testZonedDateTimeArray(boolean sparse) {
             array.setValue(i, value);
         }
         for (int i=0; i<values.length; ++i) {
-            final ZonedDateTime v1 = values[i];
+            final ZonedDateTime v1 = values[i].truncatedTo(ChronoUnit.MILLIS);
             final ZonedDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
         array.expand(200);
         Assert.assertEquals(array.length(), 200, "The array was expanded");
         for (int i=0; i<values.length; ++i) {
-            final ZonedDateTime v1 = values[i];
+            final ZonedDateTime v1 = values[i].truncatedTo(ChronoUnit.MILLIS);
             final ZonedDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
@@ -672,7 +673,7 @@ public void testZonedDateTimeArray(boolean sparse) {
             array.setValue(i, value);
         }
         for (int i=100; i<200; ++i) {
-            final ZonedDateTime v1 = values[i-100];
+            final ZonedDateTime v1 = values[i-100].truncatedTo(ChronoUnit.MILLIS);
             final ZonedDateTime v2 = array.getValue(i);
             Assert.assertEquals(v1, v2, "Values match at " + i);
         }
@@ -818,13 +819,15 @@ public <T> void testFill(Class<T> type, ArrayStyle style) {
             T value = (T)LocalDateTime.now();
             array.fill(value);
             for (int i=0; i<array.length(); ++i) {
-                Assert.assertEquals(array.getValue(i), value, "Values match at " + i);
+                LocalDateTime formattedValue = ((LocalDateTime) value).truncatedTo(ChronoUnit.MILLIS);
+                Assert.assertEquals(array.getValue(i), formattedValue, "Values match at " + i);
             }
         } else if (array.typeCode() == ArrayType.ZONED_DATETIME) {
             T value = (T)ZonedDateTime.now();
             array.fill(value);
             for (int i=0; i<array.length(); ++i) {
-                Assert.assertEquals(array.getValue(i), value, "Values match at " + i);
+                 ZonedDateTime formattedValue = ((ZonedDateTime) value).truncatedTo(ChronoUnit.MILLIS);
+                 Assert.assertEquals(array.getValue(i), formattedValue, "Values match at " + i);
             }
         } else if (array.typeCode() == ArrayType.OBJECT) {
             T value = (T)new Double(7d);
@@ -968,12 +971,12 @@ public <T> void testFirstAndLast(Class<T> type, ArrayStyle style) {
             assertFirstAndLast(array, values, arrayType);
         } else if (arrayType == ArrayType.LOCAL_DATETIME) {
             final LocalDateTime[] values = new LocalDateTime[1000];
-            for (int i=0; i<values.length; ++i) values[i] = LocalDateTime.now().plusSeconds(i);
+            for (int i=0; i<values.length; ++i) values[i] = LocalDateTime.now().plusSeconds(i).truncatedTo(ChronoUnit.MILLIS);
             final Array<LocalDateTime> array = Array.of((Class<LocalDateTime>)type, values.length, null, style).applyValues(v -> values[v.index()]);
             assertFirstAndLast(array, values, arrayType);
         } else if (arrayType == ArrayType.ZONED_DATETIME) {
             final ZonedDateTime[] values = new ZonedDateTime[1000];
-            for (int i=0; i<values.length; ++i) values[i] = ZonedDateTime.now().plusSeconds(i);
+            for (int i=0; i<values.length; ++i) values[i] = ZonedDateTime.now().plusSeconds(i).truncatedTo(ChronoUnit.MILLIS);
             final Array<ZonedDateTime> array = Array.of((Class<ZonedDateTime>)type, values.length, null, style).applyValues(v -> values[v.index()]);
             assertFirstAndLast(array, values, arrayType);
         } else if (arrayType == ArrayType.OBJECT) {