This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Notification thrown in Zend\Mvc\Service\ViewHelperManagerFactory #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Factory embedded in ViewHelperManagerFactory was not checking if services and/or array keys existed prior to accessing them.
ghost
assigned - Adds new test suite for ViewHelperManagerFactory, and adds test for specific fix from this PR.
- Used a data provider to allow testing the three various inputs that led to issues previously.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification is thrown when 'view_manager' key doesn't exits in config array on 'doctype' factory closures.