Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Resolves warning raised when version is not matched. #4893

Closed
wants to merge 1 commit into from

Conversation

elyobo
Copy link

@elyobo elyobo commented Jul 28, 2013

No description provided.

@Ocramius
Copy link
Member

Could you please provide a failing test for this one?

@elyobo
Copy link
Author

elyobo commented Jul 28, 2013

No problem. The following shows the problem; the version match is optional in the regex, so the check on line 96 may be undefined if the string doesn't contain a matching HTTP version. No idea whether that happens in practice, but you might as well handle it gracefully.

public function testRequestsWithoutHttpVersionAreOK()
{
        $requestString = "GET http://www.domain.com/index.php";
        $request = Zend\Http\Request::fromString($requestString);
}

weierophinney added a commit that referenced this pull request Aug 19, 2013
Resolves warning raised when version is not matched.
weierophinney added a commit that referenced this pull request Aug 19, 2013
weierophinney added a commit that referenced this pull request Aug 19, 2013
@ghost ghost assigned weierophinney Aug 19, 2013
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
…ttp-request-warning

Resolves warning raised when version is not matched.
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants