Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

FirePhp log writer works incorrectly with extra parameters. #6370

Closed
Redigast13 opened this issue Jun 13, 2014 · 3 comments
Closed

FirePhp log writer works incorrectly with extra parameters. #6370

Redigast13 opened this issue Jun 13, 2014 · 3 comments
Assignees
Milestone

Comments

@Redigast13
Copy link

$logger->log('some message', ['a' => 'b']);
In FirePhpWriter in doWrite() method we have this line: $firephp->info($line, $label);
Here is this info() method in FirePhpBridge class:
public function info($line)
{
return $this->firephp->info($line);
}

As you can see $label parameter is ignored. In my example message "some message" won't be shown in firebug console, there will be only array('a' => 'b').

Please, add second parameter in info(), warn(), error() e.t.c. methods in FirePhpBridge and in FirePhpInterface

@samsonasik
Copy link
Contributor

@Redigast13 can you create PR for it ?

@Redigast13
Copy link
Author

#6374

@Ocramius
Copy link
Member

Handled in #6374

@Ocramius Ocramius added this to the 2.4.0 milestone Nov 17, 2014
@Ocramius Ocramius self-assigned this Nov 17, 2014
gianarb pushed a commit to zendframework/zend-log that referenced this issue May 15, 2015
…everting BC break in interface signature, since PHP allows additional optional parameters to be defined in implementing classes
gianarb pushed a commit to zendframework/zend-log that referenced this issue May 15, 2015
…sing nullable `$label` in the `FirePhpBridge` to avoid BC breaks
gianarb pushed a commit to zendframework/zend-log that referenced this issue May 15, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants