This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
FirePhp log writer works incorrectly with extra parameters. #6370
Comments
@Redigast13 can you create PR for it ? |
Ocramius
pushed a commit
that referenced
this issue
Nov 17, 2014
Ocramius
pushed a commit
that referenced
this issue
Nov 17, 2014
Ocramius
added a commit
that referenced
this issue
Nov 17, 2014
…lows additional optional parameters to be defined in implementing classes
Handled in #6374 |
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this issue
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this issue
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this issue
May 15, 2015
…everting BC break in interface signature, since PHP allows additional optional parameters to be defined in implementing classes
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this issue
May 15, 2015
…sing nullable `$label` in the `FirePhpBridge` to avoid BC breaks
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this issue
May 15, 2015
…zendframework#6370-pass-label-to-firephp-bridge-log-writer' into develop Close zendframework/zendframework#6374 Close zendframework/zendframework#6370
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
$logger->log('some message', ['a' => 'b']);
In FirePhpWriter in doWrite() method we have this line: $firephp->info($line, $label);
Here is this info() method in FirePhpBridge class:
public function info($line)
{
return $this->firephp->info($line);
}
As you can see $label parameter is ignored. In my example message "some message" won't be shown in firebug console, there will be only array('a' => 'b').
Please, add second parameter in info(), warn(), error() e.t.c. methods in FirePhpBridge and in FirePhpInterface
The text was updated successfully, but these errors were encountered: