This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix bug in InjectTemplateListenerTest #5669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InjectTemplateListener in tests yields different results with ModuleRouteListener::MODULE_NAMESPACE router parameter set. Fix applies ModuleRouteListener to routematch parameters.
|
@Xerkus does this just add more tests for robustness? Also, re-triggered the build, as it was made when an update to the CS checker made all the CS checks blow up. |
|
CS checks are still blowing up, but looks good. Scheduling for 2.2.6. |
|
@weierophinney iirc, this change added more coverage for template listener when |
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
Fix bug in InjectTemplateListenerTest
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InjectTemplateListener in tests yields different results with
ModuleRouteListener::MODULE_NAMESPACE router parameter set.
Fix applies ModuleRouteListener to routematch parameters.