This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Zend\Soap\Server][NEW] add a getSoap method, return the internal instance #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,11 @@ class Server implements ZendServerServer | |||
| protected $class; | |||
|
|
|||
| /** | |||
| * Server instance | |||
| * @var \SoapServer | |||
There was a problem hiding this comment.
the SoapServer already in use statement, so no need to add "" prefix.
|
fixed! |
| * @var SoapServer | ||
| */ | ||
| protected $server = null; | ||
| /** |
There was a problem hiding this comment.
Let a blank line before this comment
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
[Zend\Soap\Server][NEW] add a getSoap method, return the internal instance Conflicts: tests/ZendTest/Soap/ServerTest.php Changes name of `_getSoap()` to `getSoap()`, and gives it public visibility.
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
weierophinney
added a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…pServerGetSoapServerInstance [Zend\Soap\Server][NEW] add a getSoap method, return the internal instance Conflicts: tests/ZendTest/Soap/ServerTest.php Changes name of `_getSoap()` to `getSoap()`, and gives it public visibility.
weierophinney
added a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are no able to access of the internal SoapServer instance. But in certain case (especially when we need to send a soapfault with the setReturnResponse at true) we need an access to the internal instance.
So this pull request adds a proxy method getSoap() which returns the internal SoapServer instance.
Code is unit-tested