Fixes #4521

[samsonasik]

Fixes #4521

[mwillbanks]

This could potentially have negative side effects. Generally the select instance becomes cached and this removes it which if you build out a select and then call getSelect it may rebuild the select again. Maybe it should be resolved by instantiating the object?

[samsonasik]

what you mean by instantiating the object ? the issue is when same object re-populate the options data with other option. what your suggestion ?

[weierophinney]

@samsonasik I'd argue that the better approach is to reset the $select property when any of the $table, $schema, $field, or $exclude properties change. This way the Select object can be cached and only rebuilt when necessary.

[samsonasik]

@weierophinney done ;). Added condition to reset $select only if $table, $schema, $field, or $exclude properties changed.

[weierophinney]

Wasn't quite what I was getting at, @samsonasik - but I updated it to do it properly. Essentially, whenever any of the setters are called for table, schema, field, or exclude, the $select property should be nulled, which will force getSelect() to rebuild it on next invocation.

[samsonasik]

@weierophinney thank you ;)