Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Hotfix/5640 for bug in nested Zend\Form\Element\Collection::extract() recursion #5890

Closed
wants to merge 7 commits into from

Conversation

leogr
Copy link
Contributor

@leogr leogr commented Mar 1, 2014

This PR fixes a problem in "Recursively extract and populate values for nested fieldsets" for the use case of nested collections as described by #5640

Maybe this is not the definitive solution, but it includes a test for nested collections and a fix that solves the problem without breaking any other tested behaviours.

* Zend Framework (http://framework.zend.com/)
*
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now 2014

@weierophinney weierophinney added this to the 2.2.6 milestone Mar 3, 2014
@Ocramius
Copy link
Member

Ocramius commented Mar 4, 2014

This PR requires a rebase

@Ocramius Ocramius added the Form label Mar 4, 2014
@leogr
Copy link
Contributor Author

leogr commented Mar 4, 2014

Rebase done.

I noticed that now my fix is no more needed, so I left just the test case as described in #5640

@Ocramius : is it ok?

@danizord
Copy link
Contributor

danizord commented Mar 4, 2014

👍

@weierophinney weierophinney self-assigned this Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
Hotfix/5640 for bug in nested Zend\Form\Element\Collection::extract() recursion
weierophinney added a commit that referenced this pull request Mar 4, 2014
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants