Prevent ArrayObject recursion in 5.6

[datibbaw]

In PHP 5.6(next), calling isset() on an instance of ArrayObject will invoke both offsetExists() and offsetGet(). Adding an isset() inside offsetGet() will therefore result in an infinite recursion; this is related to php-src/614.

It causes tests/ZendTest/StdLib/ParametersTest.php to fail.

This patch addresses the above issue in a backward compatible manner.

[Ocramius]

@datibbaw such a fix needs a failing test case as well... Was this check removed in 5.6?

[datibbaw]

@Ocramius A failing test case would cause a crash, I'm not sure how to provide that without breaking the entire test suite :)

[Ocramius]

@datibbaw that's pretty much what it should do :-)

[datibbaw]

@Ocramius Perhaps I misunderstood what you're asking of me. The test case that should fail is already there; tests/ZendTest/Mvc/ApplicationTest.php

[Ocramius]

@datibbaw the test should be in ZendTest\Stdlib\ArrayObjectTest to avoid any possible breakage at component level

linking php/php-src#614

[datibbaw]

@Ocramius Ah, it fails tests/ZendTest/StdLib/ParametersTest.php as well :)

[Ocramius]

@datibbaw yeah, but those are all not testing at the source. While they indeed reveal the defect, a unit test on the affected unit should be written - I can eventually poke you in room11 when I have time.

[datibbaw]

@Ocramius I'm probably a bit dense, but the affected unit is Parameters and this patch aims to fix that :)

[Ocramius]

@datibbaw I'll be sure to have an additional cup of coffee tomorrow (was dragged away by the pr title) :-)