This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
add support number of string in __construct of Priority #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weierophinney thinks you for review :) |
| @@ -42,14 +42,14 @@ public function __construct($priority, $operator = null) | |||
| $operator = isset($priority['operator']) ? $priority['operator'] : null; | |||
| $priority = isset($priority['priority']) ? $priority['priority'] : null; | |||
| } | |||
| if (!is_int($priority)) { | |||
| if (!is_int($priority) && !is_numeric($priority)) { | |||
There was a problem hiding this comment.
The function is_numeric() also allows hexadecimal, binary, octal values and also exponential parts. I think however you only want to allow numbers. In that case ctype_digit() is a better choice.
There was a problem hiding this comment.
@Martin-P oh, I think you are right, thinks :)
|
close adn start anew this PR |
This was referenced Apr 17, 2014
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a zend_logger from a config.ini, bug it just support return string type. So I add support string in __construct of Priority