This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix invalid step error caused by DST #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| use DateInterval; | |||
| use DateTime as PhpDateTime; | |||
| use DateTimezone; | |||
| * | ||
| * @var string | ||
| */ | ||
| private $_originaltimezone; |
There was a problem hiding this comment.
Please don't prefix non-public members with _
There was a problem hiding this comment.
Haha, that will teach me for copying from other tests classes!
|
Except for CS, this is mergeable |
Ocramius
added a commit
that referenced
this pull request
May 10, 2014
Ocramius
added a commit
that referenced
this pull request
May 10, 2014
Ocramius
added a commit
that referenced
this pull request
May 10, 2014
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to force UTC on the DateStepValidator, otherwise, changes in DST causes it to fail due to the base date being an hour out.