[Http] Add body support for DELETE/OPTIONS request

[egeloen]

Hey!

This PR adds support for request body with other methods such as DELETE/OPTIONS with the curl client. Currently, it is only supported with the socket client and so, this PR rationalized the behavior between all clients.

[Ocramius]

Seems related to #6318, which will land only in 2.4.

Could you eventually add a test, especially for OPTIONS (which is new here)?

[egeloen]

@Ocramius Should I add some tests which will be specific to curl or shared by all adapters?

[Ocramius]

@egeloen whatever makes more sense for you

[egeloen]

@Ocramius Done. With these tests, I have realized an other method needs to be updated accordingly.

Additionally, by running tests which requires a web server, I have noticed some tests are failing due to this line and this line (the max age is equal to -2400).

[Ocramius]

@weierophinney have we ever tried enabling the HTTP integration tests on travis?

[egeloen]

I can enable it on travis but which web server should I use? nginx, apache, an other?

[Ocramius]

We can use the internal PHP Server

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 30 July 2014 16:38, Eric GELOEN notifications@github.com wrote:

I can enable it on travis but which web server should I use? nginx,
apache, an other?

—
Reply to this email directly or view it on GitHub
#6492 (comment).

[egeloen]

I just try to use the PHP built in web server and there is lot of tests which fails (more than with a real web server). So, I'm not sure it's a good idea to rely on it.

[Ocramius]

I'm not sure if travis comes with any pre-installed web server, because I don't think we should install one during builds either.

Yes, the internal PHP server is indeed very simplified: I was hoping for it to support our necessities :\

[egeloen]

Unfortunately, travis does not come with a web server as pointed here. We need to install/configure it during the build. So, if you think it's a no go to install it, I can't do anything :s

[Ocramius]

Re-assigning to @weierophinney - I'll let this decision to him. The question here is build times, mainly.

[egeloen]

@weierophinney Can you please give me your opinion?

[Ocramius]

@egeloen I've manually merged this PR into master and develop, thanks!

master: 78a6c25
develop: 7a1c743

[egeloen]

@Ocramius Thank you too!