This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
CollectionInputFilter throws warning if invalid collection provided #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot traversable) throws php Warning: `Invalid argument supplied for foreach()`
| @@ -612,4 +612,18 @@ public function testNestedCollectionWithEmptyData() | |||
| $values = $inputFilter->getValues(); | |||
| $this->assertEquals($data, $values); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing whitespace should be removed
|
|
||
| public function testInvalidCollectionIsNotValid() | ||
| { | ||
| if (!extension_loaded('intl')) { |
There was a problem hiding this comment.
Do you need intl for this test?
There was a problem hiding this comment.
sorry copy paste fail
weierophinney
added a commit
that referenced
this pull request
Aug 7, 2014
CollectionInputFilter throws warning if invalid collection provided Conflicts: tests/ZendTest/InputFilter/CollectionInputFilterTest.php
weierophinney
added a commit
that referenced
this pull request
Aug 7, 2014
- Scalar data cannot be validated, and should be considered false.
weierophinney
added a commit
that referenced
this pull request
Aug 7, 2014
|
Fixed! Thanks for the unit test -- made it very easy to find and implement a solution. |
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
CollectionInputFilter throws warning if invalid collection provided Conflicts: tests/ZendTest/InputFilter/CollectionInputFilterTest.php
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
- Scalar data cannot be validated, and should be considered false.
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid value for foreach that means not traversable or iteratable array
throws php Warning:
Invalid argument supplied for foreach()