Method for adding extra identifiers to Abstract Controller Event Manager

[ibekiaris]

I extended the functionallity of Zend\Mvc\Controller\AbstractController because i face the following problem:

There was a need of a Zf2 module with the following structure:

Module Name: Modules

Modules

• src

-- FolderA
-- FolderB

• view

-- foldera
-- folderb

I wanted to disable the layout only for that module. So i need an identifier for that module only.

However namespace configuration was the following

   return array(
        'Zend\Loader\StandardAutoloader' => array(
                'namespaces' => array(
                   'FolderA' => __DIR__ . '/src/FolderA',
                   'FolderB' => __DIR__ . '/src/FolderB',
                ),
        ),
    );

Tha means that identifiers in AbstractController event manager are:

'Zend\Stdlib\DispatchableInterface'
'Zend\Mvc\Controller\AbstractController'
'FolderA\Controller\IndexController'
'AbstractModulesController'
'FolderA' (or FolderB)

So i ve added some lines of code in case someone need to extend AstractActionController and implement his own

"AbstractActionController" class setting also his own identifiers to the event manager.

[weierophinney]

I'd actually prefer that we use the existing $eventIdentifier property for this. To do this, remove it from the setIdentifier() call, and then do the following:

• if not an array, cast to an array
• pass the value to addIdentifiers()

If you make that change, I'll merge.

[grizzm0]

Indented with 4+5 spaces instead of 4+4.

[ibekiaris]

Hope its OK now

[weierophinney]

Keep the above, but remove the $this->eventIdentifier entry.

[ibekiaris]

I did changes there. Thank you very much for the guideness.

Just a question: why not simply casting (array cast) rather than checking if $this->eventIdentifier is array? Is there a performance matter?

Thanks in advance.

[weierophinney]

why not simply casting (array cast) rather than checking if $this->eventIdentifier is array? Is there a performance matter?

More of a "it doesn't always work the way you expect" situation, particularly with empty values.

[ibekiaris]

Thanks for the reply

[Ocramius]

@ibekiaris I added tests and manually merged into develop at a16bff4, thanks!