Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

6649 #6655

Closed
wants to merge 4 commits into from
Closed

6649 #6655

wants to merge 4 commits into from

Conversation

monkeyphp
Copy link
Contributor

I've removed the exception being throw when the valueOptions array is empty. I feel that there is a valid use case for the array to be empty - for example, in database backed forms.

@monkeyphp monkeyphp mentioned this pull request Sep 9, 2014
Closed
@Martin-P
Copy link
Contributor

What does happen when no value_options are provided? I think that needs a test case.

@Ocramius Ocramius added this to the 2.3.4 milestone Dec 24, 2014
@Ocramius Ocramius self-assigned this Dec 24, 2014
Ocramius added a commit that referenced this pull request Dec 30, 2014
@Ocramius
#6649 #6655 - rendering a multicheckbox without value options should …
4ea169e 
…produce an empty string
Ocramius added a commit that referenced this pull request Dec 30, 2014
@Ocramius
#6649 #6655 - adding @group annotations for newly introduced tests
eb4cc8c
Ocramius added a commit that referenced this pull request Dec 30, 2014
@Ocramius
Merge branch 'hotfix/#6655-#6649-allow-empty-form-element-value-optio…
5bbb449 
…ns-in-form-element-renderer' into develop

Close #6655
Close #6649
Forward port #6655
Forward port #6649
@Ocramius Ocramius closed this in 30394c8 Dec 30, 2014
@Ocramius
Copy link
Member

Merged and added tests, thanks @monkeyphp and @Martin-P!

master: 30394c8
develop: 5bbb449

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
bug Form View
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@monkeyphp @Martin-P @Ocramius @weierophinney