This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Use file_exists to check for an uploaded file. #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that stream_resolve_include_path doesn't work for a default Windows install where upload_tmp_dir is set to C:\Windows\Temp. I'm unclear if this is intended PHP behaviour or not, but the upload file validator should not be checking for a file of the same name on the include path regardless.
| @@ -74,7 +74,7 @@ public function isValid($value) | |||
|
|
|||
| switch ($error) { | |||
| case UPLOAD_ERR_OK: | |||
| if (empty($file) || false === stream_resolve_include_path($file)) { | |||
| if (empty($file) || false === file_exists($file)) { | |||
There was a problem hiding this comment.
I think is_file() is more specific, because file_exists() also returns true when it is a directory. It looks to me using file_exists() creates a way for hackers to "scan" the system for specific folders?
|
Good point @Martin-P. I've updated the PR. |
weierophinney
added a commit
that referenced
this pull request
Sep 16, 2014
Use file_exists to check for an uploaded file.
weierophinney
added a commit
that referenced
this pull request
Sep 16, 2014
|
@akrabat seems to be still a bug on windows with default path. Not in this validator, but in |
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…ix/uploadfile Use file_exists to check for an uploaded file.
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that stream_resolve_include_path doesn't work for a default
Windows install where upload_tmp_dir is set to C:\Windows\Temp. I'm
unclear if this is intended PHP behaviour or not, but the upload file
validator should not be checking for a file of the same name on the
include path regardless.