-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Test/Db/Adapter/Platform/SqlServerTest restore_error_handler(); #6790
Test/Db/Adapter/Platform/SqlServerTest restore_error_handler(); #6790
Conversation
travis build failures
|
I don't know why, but for Windows |
The original code does exactly the same as your suggestion, it only uses |
@Martin-P May be this is my enviroment, may be else. What sense to investigate this? |
@@ -142,10 +142,10 @@ public function testSetDriver() | |||
|
|||
public function testPlatformQuotesNullByteCharacter() | |||
{ | |||
$err = set_error_handler(function () {} ); | |||
set_error_handler(function () {} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the Stdlib error handler here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can use Stdlib\ErrorHandler::start()
/ Stdlib\ErrorHandler::stop()
.
But I can't see sense, because Stdlib\ErrorHandler::stop()
use restore_error_handler()
…erverTest Test/Db/Adapter/Platform/SqlServerTest restore_error_handler();
Error handler should be restore for the following tests