This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fixed #7018 : Hostname validator used disallowed unicode code points #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also removed error suppression if this kind of error should appear - CS fixes
|
@marc-mabe I have to bother you by asking you to add a test case, sorry :-\ |
|
@Ocramius The tests already exists but before they suppressed errors using the error handler. I have removed the error suppression and without the fix the tests fails. see https://github.com/zendframework/zf2/pull/7019/files#diff-6a88a164c8e6b41449f7f92cf62228a1L1304 |
|
Fair enuff :-) Thanks for explaining the diff |
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
|
@marc-mabe merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…inor CS fixes (alignment, line breaks, spacing)
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…endframework#7019-hostname-validator-disallow-invalid-unicode-code-points' into develop Close zendframework/zendframework#7018 Close zendframework/zendframework#7019
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…endframework#7019-hostname-validator-disallow-invalid-unicode-code-points' Close zendframework/zendframework#7018 Close zendframework/zendframework#7019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7018
see zendframework/zf1#322 and zendframework/zf1#472